Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Bug: 'Insert below' and 'Turn into' Always Work Relative to Block with Insertion Point #165

Closed
luxlogica opened this issue Nov 8, 2019 · 5 comments
Labels
difficulty: easy 🤩 Issue seems easy to solve type: bug 🐛 Issue is a bug; PR is a bugfix
Milestone

Comments

@luxlogica
Copy link

Description

In an Editor field with multiple paragraphs, when the user selects 'Insert Below...' or 'Turn into...' from a block menu, the operation is performed relative to the block where the insertion point currently is - not the block where the menu was opened and selected.

Steps to reproduce

  1. In an Editor field, add several paragraphs of text.
  2. Click somewhere on the first paragraph, to place your insertion point there.
  3. Scroll to the last paragraph, and clicking on its block menu, select 'Insert below...' and select any block type (doesn't matter).

What is expected

We expect the new block to be inserted below the block where the menu was activated - ie., below the last paragraph.

What actually happens

The new block is inserted below the FIRST paragraph instead - where the insertion point was.

Versions

Kirby 3.3
Editor 1.0

@MathiasGmeiner
Copy link

@luxlogica in my case it's always the block with the cursor in it.
Kapture 2019-11-13 at 11 01 21

@luxlogica
Copy link
Author

@MathiasGmeiner I think we're saying the same thing, right? The block that changes is always the block with the blinking insertion point, not the block where you opened the menu.

@MathiasGmeiner
Copy link

@luxlogica oops, yes! I got the "insertion point" wrong. Nevermind...

@bastianallgeier bastianallgeier added difficulty: easy 🤩 Issue seems easy to solve type: bug 🐛 Issue is a bug; PR is a bugfix labels Nov 18, 2019
@bastianallgeier
Copy link
Member

✅ This was weirdly only a Safari issue. But it's fixed now on the develop branch.

@MathiasGmeiner
Copy link

@bastianallgeier and Firefox. But I will try the develop branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty: easy 🤩 Issue seems easy to solve type: bug 🐛 Issue is a bug; PR is a bugfix
Projects
None yet
Development

No branches or pull requests

3 participants