Reference: support variadic parameters

Fixes #1484
getkirby · Nov 4, 2023 · cfa6d7a · cfa6d7a
1 parent 86bc50d
commit cfa6d7a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/site/plugins/site/src/Reference/ReflectionPage.php b/site/plugins/site/src/Reference/ReflectionPage.php
@@ -32,7 +32,7 @@ public function call(): string
 		}
 
 		$parameters = array_column($this->parameters(), 'export');
-		$parameters = empty($parameters) ? '' : implode(', ', $parameters);
+		$parameters = implode(', ', $parameters);
 		$call       = $this->name() . '(' . $parameters . ')';
 
 		if ($return = $this->returnType()) {
@@ -206,7 +206,13 @@ function ($parameter) {
 					$type = (string)$doc->getType();
 				}
 
-				$param    = trim($type . ' $' . $name);
+				$export = '$' . $name;
+
+				if ($parameter->isVariadic() === true) {
+					$export = '...' . $export;
+				}
+
+				$export   = trim($type . ' ' . $export);
 				$default  = null;
 				$optional = false;
 
@@ -221,16 +227,17 @@ function ($parameter) {
 					}
 
 					$optional  = true;
-					$param    .= ' = ' . $default;
+					$export   .= ' = ' . $default;
 				}
 
 				return [
 					'name'        => '$' . $name,
-					'required'    => $optional === false,
-					'type'        => Types::factory($type ?? 'mixed', $this),
 					'default'     => $default,
 					'description' => (string)$doc?->getDescription(),
-					'export'      => $param
+					'export'      => $export,
+					'required'    => $optional === false,
+					'type'        => Types::factory($type ?? 'mixed', $this),
+					'variadic'    => $parameter->isVariadic()
 				];
 			}
 		);

diff --git a/site/snippets/templates/reference/entry/parameters.php b/site/snippets/templates/reference/entry/parameters.php
@@ -43,6 +43,7 @@
       <?php foreach ($rows as $row): ?>
       <tr>
         <td>
+					<?= $row['variadic'] ? '...' : null ?>
           <?= $row['name'] ?>
           <?= Types::required($row['required']) ?>
         </td>