Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid changed data download. #5791

Closed
modufolio opened this issue Oct 13, 2023 · 6 comments
Closed

Invalid changed data download. #5791

modufolio opened this issue Oct 13, 2023 · 6 comments
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@modufolio
Copy link

modufolio commented Oct 13, 2023

Description

The data that is being downloaded doesn't seem okay, getting [object Object] in a layout field back.

Screenshots
download-changes

layout: 

[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]


To reproduce

No idea

Your setup

Kirby Version
3.9.7
4.0.0-beta.1

@bastianallgeier
Copy link
Member

Have you tried with beta 2 as well?

@distantnative
Copy link
Member

I think this could potentially be a v3 issue even

@afbora afbora changed the title [v4] Invalid changed data download. Invalid changed data download. Oct 13, 2023
@afbora
Copy link
Member

afbora commented Oct 13, 2023

Yes, the issue already in v3.

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Oct 13, 2023
@afbora
Copy link
Member

afbora commented Oct 13, 2023

We can use JSON.stringify() for array and objects. That would be correct for blocks and layout field but not for structure and object field. It needs to be encoded as yaml data (need a js yaml dependency). I think it seems difficult to detect fields type in local storage.

@lukasbestle
Copy link
Member

I'd say pretty-printed JSON would still be better than nothing even for YAML fields. The download is only meant as a backup for manual merging of changes.

@afbora
Copy link
Member

afbora commented Oct 16, 2023

Make sense. If everyone agree on using pretty JSON for all non-string data, I can prepare PR for 3.9.8 release.

@afbora afbora self-assigned this Oct 25, 2023
@afbora afbora added this to the 3.9.8 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

No branches or pull requests

5 participants