Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Field with translate: false is not dimming appearance #5957

Closed
dennisbaum opened this issue Nov 14, 2023 · 3 comments · Fixed by #5990
Closed

Object Field with translate: false is not dimming appearance #5957

dennisbaum opened this issue Nov 14, 2023 · 3 comments · Fixed by #5990
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@dennisbaum
Copy link

Description

An object-field with translate:false does not change it's appearance, if i switch to a non-default-language,
like other fields does. it only disables the inner fields

Expected behavior
The Object-Field should look like other fileds, with translate:false

DE (default) vs. EN: (compare the text-field below)
image image

To reproduce

add an object field and set translate:false and switch to a non-default language

Your setup

Kirby Version
k4-rc.1

Your system (please complete the following information)

  • Device: macbook
  • OS: macOS, 13.4.1
  • Browser: Chrome, Safari, FF
@gbdesign2023
Copy link

This display of inactive fields is identical to version 3. Or what exactly is the error?
IMG_8012

@dennisbaum
Copy link
Author

Each non translatable field is changing its appearance when selecting a non-default language.
For example also structure-fields and date-fields does. But object-fields does not.
In our opinion that is an visual error in the design-language of the panel - also in k3.

image image

@bastianallgeier
Copy link
Member

I agree. The object table should look like the structure table above.

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Nov 14, 2023
@distantnative distantnative changed the title [v4][Panel] Object Field with translate:false is not dimming appearance Object Field with translate: false is not dimming appearance Nov 14, 2023
@distantnative distantnative self-assigned this Nov 23, 2023
@distantnative distantnative added this to the 4.0.0-rc.3 milestone Nov 23, 2023
distantnative added a commit that referenced this issue Nov 23, 2023
@distantnative distantnative linked a pull request Nov 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants