Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picklist input for tags and multiselect #5822

Merged
merged 34 commits into from
Nov 9, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Oct 19, 2023

This PR …

Please have a first look at the UX and let's collect bugs, missing features...

TODO

Fixes

@bastianallgeier
Copy link
Member

The more I look at this, the more I come to the conclusion, that the tags field should also have the full list with checkboxes. It is so much more usable to see all options and select those that you want. I don't think the UX should or needs to be different for tags here. I know that there's hardly any differentiation between fields, but it really is the same pattern. You select multiple items from a list. I guess we really need to push the tags field more into a real taxonomy direction with unique ids for tags, translatable tags, etc. That would be the real differentiator in the future. But in terms of UX, I don't think that they should be so different.

@distantnative
Copy link
Member Author

I really like the styling tweaks you did.

I would argue that the current state is much more what people expect from the tags field based on v3. I get your suggestions and in that case a different UI with checkboxes would make sense, but just changing the UI right now would be not so great I think. To me, there is quite a bit of value in having a distinction of these two fields. Making them too similar, without the added functionality, just creates confusion why they are so similar and yet different fields.

@bastianallgeier bastianallgeier modified the milestones: 4.0-beta.3, 4.0-beta.4 Nov 2, 2023
@distantnative distantnative force-pushed the v4/enhancement/picklist-input branch from 3c725f6 to 52ba1ea Compare November 3, 2023 19:20
@bastianallgeier
Copy link
Member

Changes

  • New tag creation button is now directly in the filter input to build a clearer connection between the two
    Screenshot 2023-11-09 at 16 25 40
  • The show more button scrolls with the other options now which feels more natural. Once you reach the bottom of the list you can use it to the extend the list. The styling has been improved with an icon
    Screenshot 2023-11-09 at 16 32 01
  • The multiselect input has an invisible button which can be focused and will open the dropdown properly. This improves keyboard navigation.
  • The dropdown in the tags field hides the inputs in a way that keyboard accessibility is maintained
  • The search input uses "Enter" as placeholder when there are no options and "Filter" as soon as there are options.
  • The picklist-input component only introduces styles that are globally useful. Other styles moved to the picklist-dropdown or the tag and multiselect inputs.
  • The checkboxes have a fixed disabled state design in the dropdowns
  • The search input has a proper outline when focused
  • The dropdown has a narrower min width for small screens.

@bastianallgeier bastianallgeier merged commit 260ee59 into v4/develop Nov 9, 2023
7 checks passed
@bastianallgeier bastianallgeier deleted the v4/enhancement/picklist-input branch November 9, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment