Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML rendering bugs #5986

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Fix HTML rendering bugs #5986

merged 5 commits into from
Nov 23, 2023

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Nov 22, 2023 •
edited by bastianallgeier
Loading

This PR …

Fixes

  • Fix double-escaping bug in the Panel language view

Refactoring

  • Use the Vue object syntax for dynamic :style attributes to enhance the robustness and security
  • Ensure the security of the Str::safeTemplate() method against code execution attacks with an automated test

Ready?

  • Unit tests for fixed bug/feature (not really testable with PHPUnit because of the close connection to frontend code)
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@lukasbestle lukasbestle added type: bug 🐛 Is a bug; fixes a bug type: refactoring ♻️ Is about bad code; cleans up code labels Nov 22, 2023
@lukasbestle lukasbestle added this to the 4.0.0-rc.3 milestone Nov 22, 2023
@lukasbestle lukasbestle requested review from a team November 22, 2023 21:05
@lukasbestle lukasbestle self-assigned this Nov 22, 2023
@bastianallgeier bastianallgeier merged commit 71765b7 into v4/develop Nov 23, 2023
15 of 16 checks passed
@bastianallgeier bastianallgeier deleted the v4/fix/html-handling branch November 23, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distantnative distantnative distantnative approved these changes

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@lukasbestle lukasbestle

Labels
type: bug 🐛 Is a bug; fixes a bug type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
4.0.0-rc.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasbestle @bastianallgeier @distantnative