Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header wrapping for fields and sections #5994

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 23, 2023

@distantnative distantnative added this to the 4.0.0-rc.3 milestone Nov 23, 2023
@distantnative distantnative requested a review from a team November 23, 2023 15:54
@distantnative distantnative self-assigned this Nov 23, 2023
@distantnative distantnative linked an issue Nov 23, 2023 that may be closed by this pull request
@bastianallgeier
Copy link
Member

I had to set a min-width on the label to really get truncation working, but now it's fine.

I've set up a few more lab examples for the field and new ones for k-section to test this more easily. That's when I discovered that section and field components have quite some inconsistencies. So I fixed those in k-section which aren't too massive for rc.3. @distantnative could you still have another look please?

@distantnative distantnative merged commit 9df9fa6 into v4/develop Nov 24, 2023
4 checks passed
@distantnative distantnative deleted the v4/fix/5866-long-field-header-wrap branch November 24, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[v4] Field label overflows and icons stack vertically
2 participants