Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ColornameInput for more flexible color notations #5997

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Fix ColornameInput for more flexible color notations #5997

merged 2 commits into from
Nov 24, 2023

Conversation

distantnative
Copy link
Member

This PR …

Enhancement

Fixes

  • ColornameInput: only use getComputedStyle as last resort when colors library fails

@distantnative distantnative added type: enhancement ✨ Suggests an enhancement; improves Kirby type: bug 🐛 Is a bug; fixes a bug labels Nov 24, 2023
@distantnative distantnative added this to the 4.0.0-rc.3 milestone Nov 24, 2023
@distantnative distantnative requested a review from a team November 24, 2023 07:56
@distantnative distantnative self-assigned this Nov 24, 2023
@distantnative distantnative linked an issue Nov 24, 2023 that may be closed by this pull request
Color field pasting from Clipboard #5981
Closed
@distantnative distantnative merged commit 0bf81ea into v4/develop Nov 24, 2023
4 checks passed
@distantnative distantnative deleted the v4/enhancement/5981-colors-hex-without-# branch November 24, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.0.0-rc.3
Development

Successfully merging this pull request may close these issues.

Color field pasting from Clipboard
2 participants
@distantnative @bastianallgeier