-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language specific UUID URLs #6312
Conversation
Either we should add unit tests or we should be more explicit what we want to ignore for coverage. |
@distantnative I'm trying to create tests for the UUID route but I fail to setup a test environment with working UUIDs. Could you maybe have a look at the test? Why can the model not be found like that? |
Had you tried manually adding a uuid in the app setup |
Yep, I tried that too but also without luck. |
@bastianallgeier Ok I finally understood where it fails:
Alternatively, solving #5181 too. |
6915ab0
to
8f363c7
Compare
@bastianallgeier Apparently, sometimes it takes months to realize what one is overlooking. I even wrote
But only today it clicked that, well yea then we need to add a |
b124c32
to
12b4e4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bastianallgeier Please check if the unit test is testing the right things from your perspective.
@distantnative yes, looks good to me! I can't believe that we might actually be able to merge this :) |
This PR …
This is an attempt to finally get parts of the multi-language UUID issues solved. (#5551)
This adds a new route for language-specific UUID urls:
Examples:
Docs
Ready?
For review team