Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load .env file in Vite builds #6516

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Load .env file in Vite builds #6516

merged 2 commits into from
Jun 28, 2024

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Jun 28, 2024

Description

Summary of changes

Ensure that variables from .env are available in process.env during Vite builds

Reasoning

Allows to override options like SERVER (ex VUE_APP_DEV_SERVER)

Changelog

Housekeeping

  • Fix support for .env files in the Panel Vite build config
  • Use SERVER as name for the Vite host override env variable

Breaking changes

None

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@lukasbestle lukasbestle added the type: regression 🚨 Is a regression between versions label Jun 28, 2024
@lukasbestle lukasbestle added this to the 5.0.0-alpha.2 milestone Jun 28, 2024
@lukasbestle lukasbestle self-assigned this Jun 28, 2024
@lukasbestle lukasbestle changed the base branch from v5/develop to develop-patch June 28, 2024 19:25
@lukasbestle lukasbestle modified the milestones: 5.0.0-alpha.2, 4.3.1 Jun 28, 2024
@lukasbestle lukasbestle merged commit 5d84c2d into develop-patch Jun 28, 2024
4 checks passed
@lukasbestle lukasbestle deleted the v5/fix/vite-env branch June 28, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression 🚨 Is a regression between versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants