Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App::io(): redirect NotFoundException to error #6553

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

distantnative
Copy link
Member

Changelog

Fixes

  • Kirby\Exception\NotFoundException thrown during page rendering now redirects request to the error page (with 404); as Kirby\Exception\ErrorPageException already does

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jul 21, 2024
@distantnative distantnative added this to the 4.4.0 milestone Jul 21, 2024
@distantnative distantnative self-assigned this Jul 21, 2024
@distantnative distantnative linked an issue Jul 21, 2024 that may be closed by this pull request
@distantnative distantnative marked this pull request as ready for review July 21, 2024 17:39
@distantnative distantnative requested a review from a team July 21, 2024 17:39
@bastianallgeier bastianallgeier merged commit 2c2bc72 into develop-minor Jul 22, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/6466-app-io-notfoundexception branch July 22, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throwing NotFoundException results in 500 error page
2 participants