Redirect language URLs with non-translated slugs #6601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Reasoning
To make those pages only available under the main (full- translated) URL and not several ones (with untranslated slug parts).
Additional context
In #3550 (comment) under "Complex example", @lukasbestle asks for an additional unit test where the translated slug of a page is the same as the untranslated slug of another page. This unit test is not included here as it would fail. However, this behavior is also different before this PR: if a translated slug is the same as the untranslated slug of a different page, our router will return the different page. Moreover, our page rules also prevent creating a translated slug that matches an existing untranslated slug. This is why I didn't include this aspect in this PR. To me this seems as a much larger change to be discussed, while this PR implements the solution for #3550 based on the existing rules.
Changelog
Fixes
Ready?
For review team