Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeUrl dialog: include language URL in path #6607

Merged
merged 1 commit into from
Aug 12, 2024
Merged

ChangeUrl dialog: include language URL in path #6607

merged 1 commit into from
Aug 12, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 11, 2024 •
edited
Loading

Description

Summary of changes

  • Change URL dialog: in multilang, show the language URL segment as part of the path preview

Reasoning

Makes it easier to understand what slug you're currently editing (pre-PR the dialog looks the same whether you're editing the main language/actual slug or just a translation)

Additional context

  • I'd suggest to ignore the code coverage warning as this doesn't really change anything in this regard. And I'd love to wait for moving dialogs to UI classes before adding unit tests.

Changelog

Enhancements

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Aug 11, 2024
@distantnative distantnative self-assigned this Aug 11, 2024
@distantnative distantnative added this to the 4.4.0 milestone Aug 11, 2024
@distantnative distantnative linked an issue Aug 11, 2024 that may be closed by this pull request
Change URL dialog: not displaying language URL prefix #6600
Closed
@distantnative distantnative marked this pull request as ready for review August 11, 2024 18:28
@distantnative distantnative requested a review from a team August 11, 2024 18:28
@distantnative distantnative merged commit 7e6a373 into develop-minor Aug 12, 2024
11 of 12 checks passed
@distantnative distantnative deleted the enhancement/6600-change-url-dialog-language-path branch August 12, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Change URL dialog: not displaying language URL prefix
2 participants
@distantnative @bastianallgeier