Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel.upload: emit open event #6621

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

distantnative
Copy link
Member

Description

Summary of changes

  • Expose the dialog's open event to panel.upload

Reasoning

E.g. to allow automatically submitting the dialog/upload once the files have been picked up(and subsequently the dialog has opened).

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Aug 15, 2024
@distantnative distantnative added this to the 4.5.0 milestone Aug 15, 2024
@distantnative distantnative requested a review from a team August 15, 2024 21:04
@distantnative distantnative self-assigned this Aug 15, 2024
@distantnative distantnative marked this pull request as ready for review August 15, 2024 21:04
@bastianallgeier
Copy link
Member

bastianallgeier commented Aug 16, 2024

🚨 do not merge into develop-minor while 4.4.0-rc is running

@distantnative distantnative merged commit 0f7de37 into develop-minor Aug 17, 2024
4 checks passed
@distantnative distantnative deleted the fix/panel-upload-emit-open branch August 17, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants