Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating new language variables for secondary languages #6622

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix updating new language variables for secondary languages #6622

merged 1 commit into from
Sep 11, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Aug 16, 2024 •
edited by bastianallgeier
Loading

Description

If you try to edit (without any update, open dialog and try to submit) new language variables from secondary language, you'll get following error in dialog.

Kirby\Cms\LanguageVariable::update(): Argument # 1 ($value) must be of type string, null given, called in \kirby\config\areas\languages\dialogs.php on line 258

Fixes

  • Fixed updating new language variables for secondary languages

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Aug 16, 2024
@afbora afbora requested a review from a team August 16, 2024 12:51
@afbora afbora self-assigned this Aug 16, 2024
@afbora afbora force-pushed the fix/updating-null-language-variables branch from d3e41ac to 096689f Compare August 17, 2024 08:09
@afbora afbora requested review from a team and distantnative August 17, 2024 08:10
@afbora afbora force-pushed the fix/updating-null-language-variables branch from 096689f to c2170dd Compare August 17, 2024 10:37
@afbora afbora marked this pull request as draft August 18, 2024 21:45
@distantnative distantnative added this to the 4.5.0 milestone Aug 31, 2024
@afbora afbora force-pushed the fix/updating-null-language-variables branch from c2170dd to 704185b Compare September 10, 2024 11:25
@afbora afbora force-pushed the fix/updating-null-language-variables branch from 704185b to 303e669 Compare September 10, 2024 11:26
@afbora afbora marked this pull request as ready for review September 10, 2024 11:26
@bastianallgeier bastianallgeier merged commit e429933 into develop-minor Sep 11, 2024
13 of 14 checks passed
@bastianallgeier bastianallgeier deleted the fix/updating-null-language-variables branch September 11, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@distantnative distantnative Awaiting requested review from distantnative

Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@afbora @bastianallgeier @distantnative