Remove roles count check from UserPermissions
#6658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
$user->roles($purpose)
#6653 firstUserRules
#6657 firstSummary of changes
UserPermissions::canChangeRole()
Reasoning
It's not a permissions question but a UI thing to disable a button if only one role is available. Permission-wise, a user should be able to change a role even if only to the one available option.
This change is also needed to avoid a circular loop:
$user->roles('change')
filters the role collection by those that can be changed$user->roles('change')
This is why this check should not be part of the permissions method.
Ready?