Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page create dialog: allow toggle field #6669

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Page create dialog: allow toggle field #6669

merged 1 commit into from
Sep 13, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Sep 12, 2024 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • Allow using toggle field in page create dialog

Reasoning

I think we simply forgot to add it to the allowlist.

Changelog

Fixes

  • Page create dialog: toggle field allowed

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Sep 12, 2024
@distantnative distantnative self-assigned this Sep 12, 2024
@distantnative distantnative marked this pull request as ready for review September 12, 2024 20:21
@distantnative distantnative requested a review from a team September 12, 2024 20:21
@bastianallgeier bastianallgeier added this to the 4.5.0 milestone Sep 13, 2024
@bastianallgeier bastianallgeier merged commit 0033956 into develop-minor Sep 13, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/page-create-dialog-toggle-field branch September 13, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier