Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move page: allow parent without any pages sections #6717

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Oct 2, 2024

Description

  • Unit test

Summary of changes

  • Allow any templates as children for a page that does not define any pages sections or only sections with no template restrictions

Reasoning

It's confusing why currently no template is accepted when moving, while no template restrictions exists for the page.

Additional context

Could be seen a breaking change but I think the current behavior is more a unexpected bug.

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added type: enhancement ✨ Suggests an enhancement; improves Kirby type: bug 🐛 Is a bug; fixes a bug labels Oct 2, 2024
@distantnative distantnative added this to the 4.5.0 milestone Oct 2, 2024
@distantnative distantnative self-assigned this Oct 2, 2024
@distantnative distantnative marked this pull request as ready for review October 3, 2024 09:24
@distantnative distantnative requested a review from a team October 3, 2024 09:24
@bastianallgeier
Copy link
Member

I remember that I thought that a page should only really be allowed to have children if this is defined with page sections. But I think I agree now after a while that this is too strict. If you move a page into another page that does not have any page sections, nothing bad will truly happen. The only problem might be that you are no longer able to find that page later, except by searching it.

@distantnative distantnative merged commit 4bb9013 into develop-minor Oct 3, 2024
12 checks passed
@distantnative distantnative deleted the fix/page-rules-move branch October 3, 2024 12:19
@distantnative distantnative mentioned this pull request Oct 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants