Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-language fixes #6732

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Conversation

bastianallgeier
Copy link
Member

Description

Summary of changes

  • Version::exists has a new wildcard option to check if a version exists in any language. E.g. $page->version('changes')->exists('*') We had this in an earlier draft where you could pass null to achieve this. But needing this again, I thought that the wildcard is helping to avoid confusion. It could be indeed an option for more places like this later.
  • I made sure to always get the current language in more places to fix bugs when changing the language.
  • Tracking changes has been improved and the wildcard above is used to untrack model changes properly if there are no more changes in any other language.
  • The lock field is now stored in every language file. This will already help to simplify the logic and it already enables the option to work on translations side by side. This has been possible before as well, when we stored stuff in local storage.
  • The lock field is now properly removed from the published version.

@bastianallgeier bastianallgeier force-pushed the v5/changes/multi-language branch from ee47c98 to 0a54912 Compare October 9, 2024 11:53
@bastianallgeier bastianallgeier force-pushed the v5/changes/multi-language branch from 245ba31 to ea53fe6 Compare October 9, 2024 12:57
@bastianallgeier bastianallgeier merged commit 937649e into v5/changes/develop Oct 9, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/multi-language branch October 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants