Use Imagick class
#6754
Draft
Use Imagick class
#6754
+357
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have any idea about IM. I've run unit tests. Getting following error for all provider for
|
afbora
reviewed
Oct 16, 2024
Comment on lines
+139
to
+149
| $this->threads($image, $options); | ||
| $image->stripImage(); | ||
| $this->interlace($image, $options); | ||
|
|
||
| $image = $this->coalesce($image); | ||
| $this->grayscale($image, $options); | ||
| $this->autoOrient($image); | ||
| $this->resize($image, $options); | ||
| $this->quality($image, $options); | ||
| $image = $this->blur($image, $options); | ||
| $image = $this->sharpen($image, $options); |
There was a problem hiding this comment.
Why do some return void and some return object? Can't we all return void or object?
There was a problem hiding this comment.
Some Imagick methods return a new object, some alter it in place. I don't like it much either, but I didn't find methods that behave in one way or the other consistently.
There was a problem hiding this comment.
For ex: can't we do that? If we return itself, it doesn't work?
protected function grayscale(Imagick $image, array $options): Imagick
{
if ($options['grayscale'] === true) {
$image->setColorspace(Imagick::COLORSPACE_GRAY);
}
return $image;
}
distantnative
force-pushed
the
v5/refactor/imagick
branch
from
9047372
to
1e35132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ImagickobjectSummary of changes
Imagickclass forimdarkroom driverim-legacy(LegacyImageMagickclass)@afbora Maybe you have some ideas here or could try to tackle some as well 🙏
Changelog
Fixes
Breaking changes
Docs
Ready?
For review team