Use Symfony YAML handler #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianallgeier
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
I've clicked through all the panel views and couldn't find any issues. I think it's a good idea to already activate the new handler here.
I wonder if we should add a comment to the config to explain why we use that setting and what it means? It could be helpful for starterkit users, to understand this some more.
|
@bastianallgeier thinking about it. Maybe we wait for 4.5 with getkirby/kirby#6638 included? Yes to the comment. |
|
What could be a good comment?
|
|
That comment suggestion is great! |
|
Added the comment |
bastianallgeier
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Only merge after 4.5.0 release
Description
Summary of changes
Reasoning
Before we switch the default in the Core, it would be good to run our kits first with this handler. Gives us more chances to catch any issues/differences that the new handler has, which would then allow us to make the default switch easier for developers.