[data] make Tag[Defer] compact
#849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
reviewed
Nov 17, 2024
| @@ -5,7 +5,7 @@ package object kernel: | |||
| enum Mode derives CanEqual: | |||
| case Development, Staging, Production | |||
|
|
|||
| private object internal: | |||
| private[kyo] object internal: | |||
There was a problem hiding this comment.
I'd prefer to avoid making this visible to the rest of the codebase. An important aspect of the last major redesign was to avoid having code that uses the internal representation of the pending type outside of the kernel. It makes it easier to evolve the kernel in isolation. Can you make only Defer private[kyo]? It could be in the package object instead.
There was a problem hiding this comment.
I could also create a test in the kernel namespace.
hearnadam
force-pushed
the
defer-compact
branch
from
c0e7105 to
787ee95
Compare
hearnadam
force-pushed
the
defer-compact
branch
from
787ee95 to
ad9bb4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.