[prelude] make Stream lazier #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
reviewed
Nov 19, 2024
fwbrasil
reviewed
Nov 19, 2024
hearnadam
force-pushed
the
lazy-stream
branch
2 times, most recently
from
9f4646a to
0737e59
Compare
- stop using class member, enforcing accidental eagerness - add new method: Stream.range to simplify creation of streams - init/range: accept `chunkSize` to limit size of Chunks - Chunk.from (Array): remove AnyRef type bound
hearnadam
force-pushed
the
lazy-stream
branch
from
0737e59 to
8c86758
Compare
hearnadam
commented
Nov 20, 2024
| val _chunkSize = chunkSize max 1 | ||
|
|
||
| Emit.andMap(Chunk.empty[Int]) { ack => | ||
| Loop(start, ack) { (current, ack) => |
There was a problem hiding this comment.
The contents of this loop can probably be simplified. I can take a look later.
fwbrasil
reviewed
Nov 20, 2024
fwbrasil
reviewed
Nov 20, 2024
fwbrasil
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chunkSizeto limit size of Chunks- Chunk.from (Array): remove AnyRef type boundThe first PR to address #679. This change is important to ensure the laziness of streams initialized from non-effectful sources.