[scheduler] scala native support #866
Conversation
fwbrasil
force-pushed
the
scheduler-native
branch
from
f362727 to
2679f0d
Compare
| @@ -92,7 +93,8 @@ abstract private class Worker( | |||
|
|
|||
| val a1, a2, a3, a4, a5, a6, a7 = 0L // padding | |||
|
|
|||
| @volatile private var state: State = State.Idle | |||
| private val state = new AtomicReference[State](State.Idle) | |||
There was a problem hiding this comment.
Scala Native doesn't support method handles. This change might have a performance penalty but it seems worth it.
| @@ -0,0 +1,11 @@ | |||
| package kyo.scheduler.util | |||
There was a problem hiding this comment.
Should this be shared with JS?
There was a problem hiding this comment.
The scheduler in JS is a separate and much simpler implementation since the runtime doesn't support threads. JS doesn't require a stub for this.
| private[scheduler] def statsScope = | ||
| StatsRegistry.scope("kyo", "scheduler") | ||
|
|
||
| private[scheduler] def bug(msg: String, ex: Throwable) = | ||
| log.log(Level.SEVERE, s"🙈 !!Kyo Scheduler Bug!!", new Exception(msg, ex)) | ||
| new Exception(s"🙈 !!Kyo Scheduler Bug!! " + msg, ex).printStackTrace() |
There was a problem hiding this comment.
There's no java logging in native. Logging to the standard err seems reasonable for a bug.
There was a problem hiding this comment.
There is! https://github.com/scala-native/scala-native-java-logging
Guess which project motivated me to make the port of this library? Kyo itself 😄
There was a problem hiding this comment.
I've opened a PR #868
There was a problem hiding this comment.
ha! pretty cool :) It's nice to see the ecosystem growing. I was a bit skeptical of Scala Native initially but I think that was skewed by my experience working with Graal. Many Scala projects are mostly self-contained code that are trivial to port to Native if the ecosystem is more mature. Graal is great but it can also be a nightmare to set up. I'd say the odds is that kyo-tapir will have a Scala Native version before one that works on GraalVM Native 😅
First step to support Scala Native in
kyo-core.