[scheduler] cats-effect integration #909
Conversation
| @@ -41,6 +41,14 @@ object Task { | |||
| val Preempted: Result = true | |||
| val Done: Result = false | |||
|
|
|||
| def apply(runnable: Runnable): Task = | |||
There was a problem hiding this comment.
I inspected SchedulingBench, the top benchmark with regression, and noticed that we can avoid an allocation with this dedicated constructor. I also noticed that IOFiber has a few hot code paths with special treatment for the default work stealing thread pool, which should account for some of the regression with a custom thread pool.
There was a problem hiding this comment.
LGTM! Can we create a simple mechanisms for users of kyo-zio and kyo-cats use the scheduler? Should those modules depend on the related scheduler modules?
On second thought, do we even need separate modules? Can we just compile the scheduler code for scala2/3 and the effect interop for scala 3?
The goal of the separate artifact is to allow adopting Kyo's scheduler in isolation without the effect system. If we merged the modules, it wouldn't be possible to provide Scala 2 artifacts as well. I think we can address this via documentation mentioning that users can use |
Benchmark results are mixed but use in realistic workloads might yield significant improvements, especially in containerized environments given Kyo's adaptive concurrency control.