Skip to content

Commit

Permalink
feat(netsuite): Add shipping and billing address to create contact pa…
Browse files Browse the repository at this point in the history 
…yload
  • Loading branch information
@ivannovosad
ivannovosad committed Aug 20, 2024
1 parent 3a70c5c commit 0e8ad7f
Show file tree
Hide file tree
Showing 6 changed files with 277 additions and 13 deletions.
11 changes: 11 additions & 0 deletions app/models/customer.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,17 @@ def shipping_address
}
end

def same_billing_and_shipping_address?
return true if shipping_address.values.all?(&:blank?)

address_line1 == shipping_address_line1 &&
address_line2 == shipping_address_line2 &&
city == shipping_city &&
zipcode == shipping_zipcode &&
state == shipping_state &&
country == shipping_country
end

private

def ensure_slug
Expand Down
64 changes: 62 additions & 2 deletions app/services/integrations/aggregator/contacts/payloads/netsuite.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class Netsuite < BasePayload
def create_body
{
'type' => 'customer', # Fixed value
'isDynamic' => false, # Fixed value
'isDynamic' => true, # Fixed value
'columns' => {
'companyname' => customer.name,
'subsidiary' => subsidiary_id,
Expand All @@ -21,7 +21,8 @@ def create_body
},
'options' => {
'ignoreMandatoryFields' => false # Fixed value
}
},
'lines' => lines
}
end

Expand All @@ -46,6 +47,65 @@ def update_body

private

def lines
if customer.same_billing_and_shipping_address?
[
{
'lineItems' => [
{
'defaultshipping' => true,
'defaultbilling' => true,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.address_line1,
'addr2' => customer.address_line2,
'city' => customer.city,
'zip' => customer.zipcode,
'state' => customer.state,
'country' => customer.country
}
}
],
'sublistId' => 'addressbook'
}
]
else
[
{
'lineItems' => [
{
'defaultshipping' => false,
'defaultbilling' => true,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.address_line1,
'addr2' => customer.address_line2,
'city' => customer.city,
'zip' => customer.zipcode,
'state' => customer.state,
'country' => customer.country
}
},
{
'defaultshipping' => true,
'defaultbilling' => false,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.shipping_address_line1,
'addr2' => customer.shipping_address_line2,
'city' => customer.shipping_city,
'zip' => customer.shipping_zipcode,
'state' => customer.shipping_state,
'country' => customer.shipping_country
}
}
],
'sublistId' => 'addressbook'
}
]
end
end

def customer_url
url = ENV["LAGO_FRONT_URL"].presence || "https://app.getlago.com"

Expand Down
18 changes: 18 additions & 0 deletions spec/factories/customers.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,23 @@
legal_name { Faker::Company.name }
legal_number { Faker::Company.duns_number }
currency { 'EUR' }

trait :with_shipping_address do
shipping_address_line1 { Faker::Address.street_address }
shipping_address_line2 { Faker::Address.secondary_address }
shipping_city { Faker::Address.city }
shipping_zipcode { Faker::Address.zip_code }
shipping_state { Faker::Address.state }
shipping_country { Faker::Address.country_code }
end

trait :with_same_billing_and_shipping_address do
shipping_address_line1 { address_line1 }
shipping_address_line2 { address_line2 }
shipping_city { city }
shipping_zipcode { zipcode }
shipping_state { state }
shipping_country { country }
end
end
end
30 changes: 30 additions & 0 deletions spec/models/customer_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -290,4 +290,34 @@
end
end
end

describe '#same_billing_and_shipping_address?' do
subject(:method_call) { customer.same_billing_and_shipping_address? }

context 'when shipping address is present' do
context 'when shipping address is not the same as billing address' do
let(:customer) { build_stubbed(:customer, :with_shipping_address) }

it 'returns false' do
expect(subject).to eq(false)
end
end

context 'when shipping address is the same as billing address' do
let(:customer) { build_stubbed(:customer, :with_same_billing_and_shipping_address) }

it 'returns true' do
expect(subject).to eq(true)
end
end
end

context 'when shipping address is not present' do
let(:customer) { build_stubbed(:customer) }

it 'returns true' do
expect(subject).to eq(true)
end
end
end
end
50 changes: 45 additions & 5 deletions spec/services/integrations/aggregator/contacts/create_service_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
RSpec.describe Integrations::Aggregator::Contacts::CreateService do
subject(:service_call) { described_class.call(integration:, customer:, subsidiary_id:) }

let(:customer) { create(:customer, organization:) }
let(:customer) { create(:customer, :with_same_billing_and_shipping_address, organization:) }
let(:subsidiary_id) { '1' }
let(:organization) { create(:organization) }
let(:lago_client) { instance_double(LagoHttpClient::Client) }
Expand Down Expand Up @@ -46,7 +46,7 @@
let(:params) do
{
'type' => 'customer',
'isDynamic' => false,
'isDynamic' => true,
'columns' => {
'companyname' => customer.name,
'subsidiary' => subsidiary_id,
Expand All @@ -59,7 +59,27 @@
},
'options' => {
'ignoreMandatoryFields' => false
}
},
'lines' => [
{
'lineItems' => [
{
'defaultshipping' => true,
'defaultbilling' => true,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.address_line1,
'addr2' => customer.address_line2,
'city' => customer.city,
'zip' => customer.zipcode,
'state' => customer.state,
'country' => customer.country
}
}
],
'sublistId' => 'addressbook'
}
]
}
end

Expand Down Expand Up @@ -159,7 +179,7 @@
let(:params) do
{
'type' => 'customer',
'isDynamic' => false,
'isDynamic' => true,
'columns' => {
'companyname' => customer.name,
'subsidiary' => subsidiary_id,
Expand All @@ -172,7 +192,27 @@
},
'options' => {
'ignoreMandatoryFields' => false
}
},
'lines' => [
{
'lineItems' => [
{
'defaultshipping' => true,
'defaultbilling' => true,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.address_line1,
'addr2' => customer.address_line2,
'city' => customer.city,
'zip' => customer.zipcode,
'state' => customer.state,
'country' => customer.country
}
}
],
'sublistId' => 'addressbook'
}
]
}
end

Expand Down
117 changes: 111 additions & 6 deletions spec/services/integrations/aggregator/contacts/payloads/netsuite_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

RSpec.describe Integrations::Aggregator::Contacts::Payloads::Netsuite do
let(:integration) { integration_customer.integration }
let(:customer) { integration_customer.customer }
let(:integration_customer) { FactoryBot.create(:netsuite_customer) }
let(:integration_customer) { FactoryBot.create(:netsuite_customer, customer:) }
let(:customer) { create(:customer) }
let(:subsidiary_id) { Faker::Number.number(digits: 2) }
let(:payload) { described_class.new(integration:, customer:, integration_customer:, subsidiary_id:) }
let(:customer_link) { payload.__send__(:customer_url) }
Expand All @@ -16,7 +16,7 @@
let(:payload_body) do
{
'type' => 'customer',
'isDynamic' => false,
'isDynamic' => true,
'columns' => {
'companyname' => customer.name,
'subsidiary' => subsidiary_id,
Expand All @@ -29,12 +29,117 @@
},
'options' => {
'ignoreMandatoryFields' => false
}
},
'lines' => lines
}
end

it "returns the payload body" do
expect(subject).to eq payload_body
context 'when shipping address is present' do
context 'when shipping address is not the same as billing address' do
let(:customer) { create(:customer, :with_shipping_address) }

let(:lines) do
[
{
'lineItems' => [
{
'defaultshipping' => false,
'defaultbilling' => true,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.address_line1,
'addr2' => customer.address_line2,
'city' => customer.city,
'zip' => customer.zipcode,
'state' => customer.state,
'country' => customer.country
}
},
{
'defaultshipping' => true,
'defaultbilling' => false,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.shipping_address_line1,
'addr2' => customer.shipping_address_line2,
'city' => customer.shipping_city,
'zip' => customer.shipping_zipcode,
'state' => customer.shipping_state,
'country' => customer.shipping_country
}
}
],
'sublistId' => 'addressbook'
}
]
end

it 'returns the payload body' do
expect(subject).to eq payload_body
end
end

context 'when shipping address is the same as billing address' do
let(:customer) { create(:customer, :with_same_billing_and_shipping_address) }

let(:lines) do
[
{
'lineItems' => [
{
'defaultshipping' => true,
'defaultbilling' => true,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.address_line1,
'addr2' => customer.address_line2,
'city' => customer.city,
'zip' => customer.zipcode,
'state' => customer.state,
'country' => customer.country
}
}
],
'sublistId' => 'addressbook'
}
]
end

it 'returns the payload body' do
expect(subject).to eq payload_body
end
end
end

context 'when shipping address is not present' do
let(:customer) { create(:customer) }

let(:lines) do
[
{
'lineItems' => [
{
'defaultshipping' => true,
'defaultbilling' => true,
'subObjectId' => 'addressbookaddress',
'subObject' => {
'addr1' => customer.address_line1,
'addr2' => customer.address_line2,
'city' => customer.city,
'zip' => customer.zipcode,
'state' => customer.state,
'country' => customer.country
}
}
],
'sublistId' => 'addressbook'
}
]
end

it 'returns the payload body' do
expect(subject).to eq payload_body
end
end
end

Expand Down

0 comments on commit 0e8ad7f

Please sign in to comment.