Wrap payment request and invoices payment status update...

within a database transaction
getlago · Aug 26, 2024 · 79a97cd · 79a97cd
1 parent 3224256
commit 79a97cd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/app/services/payment_requests/payments/adyen_service.rb b/app/services/payment_requests/payments/adyen_service.rb
@@ -42,11 +42,14 @@ def create
           provider_payment_id: res.response['pspReference'],
           status: res.response['resultCode']
         )
-        payment.save!
 
-        payable_payment_status = payable_payment_status(payment.status)
-        update_payable_payment_status(payment_status: payable_payment_status)
-        update_invoices_payment_status(payment_status: payable_payment_status)
+        ActiveRecord::Base.transaction do
+          payment.save!
+
+          payable_payment_status = payable_payment_status(payment.status)
+          update_payable_payment_status(payment_status: payable_payment_status)
+          update_invoices_payment_status(payment_status: payable_payment_status)
+        end
 
         Integrations::Aggregator::Payments::CreateJob.perform_later(payment:) if payment.should_sync_payment?
 

diff --git a/app/services/payment_requests/payments/stripe_service.rb b/app/services/payment_requests/payments/stripe_service.rb
@@ -40,17 +40,20 @@ def create
           provider_payment_id: stripe_result.id,
           status: stripe_result.status
         )
-        payment.save!
 
-        payable_payment_status = payable_payment_status(payment.status)
-        update_payable_payment_status(
-          payment_status: payable_payment_status,
-          processing: payment.status == 'processing'
-        )
-        update_invoices_payment_status(
-          payment_status: payable_payment_status,
-          processing: payment.status == 'processing'
-        )
+        ActiveRecord::Base.transaction do
+          payment.save!
+
+          payable_payment_status = payable_payment_status(payment.status)
+          update_payable_payment_status(
+            payment_status: payable_payment_status,
+            processing: payment.status == 'processing'
+          )
+          update_invoices_payment_status(
+            payment_status: payable_payment_status,
+            processing: payment.status == 'processing'
+          )
+        end
 
         result.payment = payment
         result