feat(netsuite): Cleanup syncs (#2782)

## Context

When a users searches for items to map the UI is not displaying all the
items. There is a reason for this
is that the NetSuite SuiteScript limits to 1000 results.

## Description

This PR we change the way we map the items. Instead of selecting the
items from a prefetched list, the user needs to manually fill out the
name, code, and the account id.

app/graphql/mutations/integrations/netsuite/create.rb

@@ -18,8 +18,7 @@ class Create < BaseMutation
 
         def resolve(**args)
           result = ::Integrations::Netsuite::CreateService
-            .new(context[:current_user])
-            .call(**args.merge(organization_id: current_organization.id))
+            .call(params: args.merge(organization_id: current_organization.id))
 
           result.success? ? result.integration : result_error(result)
         end

app/graphql/types/mutation_type.rb

@@ -71,7 +71,6 @@ class MutationType < Types::BaseObject
 
     field :fetch_integration_accounts, mutation: Mutations::IntegrationItems::FetchAccounts
     field :fetch_integration_items, mutation: Mutations::IntegrationItems::FetchItems
-    field :fetch_integration_tax_items, mutation: Mutations::IntegrationItems::FetchTaxItems
 
     field :sync_crm_integration_invoice, mutation: Mutations::Integrations::SyncCrmInvoice
     field :sync_integration_credit_note, mutation: Mutations::Integrations::SyncCreditNote

app/jobs/integrations/aggregator/perform_sync_job.rb

@@ -8,16 +8,13 @@ class PerformSyncJob < ApplicationJob
       retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
       retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
 
-      def perform(integration:, sync_tax_items: false)
+      def perform(integration:, sync_items: true)
         sync_result = Integrations::Aggregator::SyncService.call(integration:)
         sync_result.raise_if_error!
 
-        items_result = Integrations::Aggregator::ItemsService.call(integration:)
-        items_result.raise_if_error!
-
-        if sync_tax_items
-          tax_items_result = Integrations::Aggregator::TaxItemsService.call(integration:)
-          tax_items_result.raise_if_error!
+        if sync_items
+          items_result = Integrations::Aggregator::ItemsService.call(integration:)
+          items_result.raise_if_error!
         end
       end
     end

app/services/integrations/aggregator/sync_service.rb

@@ -26,11 +26,7 @@ def sync_list
         list = case integration.type
         when 'Integrations::NetsuiteIntegration'
           {
-            accounts: 'netsuite-accounts-sync',
-            items: 'netsuite-items-sync',
-            subsidiaries: 'netsuite-subsidiaries-sync',
-            contacts: 'netsuite-contacts-sync',
-            tax_items: 'netsuite-tax-items-sync'
+            subsidiaries: 'netsuite-subsidiaries-sync'
           }
         when 'Integrations::XeroIntegration'
           {
@@ -41,7 +37,6 @@ def sync_list
         end
 
         return [list[:items]] if options[:only_items]
-        return [list[:tax_items]] if options[:only_tax_items]
         return [list[:accounts]] if options[:only_accounts]
 
         list.values

app/services/integrations/netsuite/create_service.rb

@@ -3,38 +3,43 @@
 module Integrations
   module Netsuite
     class CreateService < BaseService
-      def call(**args)
-        organization = Organization.find_by(id: args[:organization_id])
+      attr_reader :params
+
+      def initialize(params:)
+        @params = params
+
+        super
+      end
+
+      def call
+        organization = Organization.find_by(id: params[:organization_id])
 
         unless organization.premium_integrations.include?('netsuite')
           return result.not_allowed_failure!(code: 'premium_integration_missing')
         end
 
         integration = Integrations::NetsuiteIntegration.new(
           organization:,
-          name: args[:name],
-          code: args[:code],
-          client_id: args[:client_id],
-          client_secret: args[:client_secret],
-          account_id: args[:account_id],
-          token_id: args[:token_id],
-          token_secret: args[:token_secret],
-          connection_id: args[:connection_id],
-          script_endpoint_url: args[:script_endpoint_url],
-          sync_credit_notes: ActiveModel::Type::Boolean.new.cast(args[:sync_credit_notes]),
-          sync_invoices: ActiveModel::Type::Boolean.new.cast(args[:sync_invoices]),
-          sync_payments: ActiveModel::Type::Boolean.new.cast(args[:sync_payments]),
-          sync_sales_orders: ActiveModel::Type::Boolean.new.cast(args[:sync_sales_orders])
+          name: params[:name],
+          code: params[:code],
+          client_id: params[:client_id],
+          client_secret: params[:client_secret],
+          account_id: params[:account_id],
+          token_id: params[:token_id],
+          token_secret: params[:token_secret],
+          connection_id: params[:connection_id],
+          script_endpoint_url: params[:script_endpoint_url],
+          sync_credit_notes: ActiveModel::Type::Boolean.new.cast(params[:sync_credit_notes]),
+          sync_invoices: ActiveModel::Type::Boolean.new.cast(params[:sync_invoices]),
+          sync_payments: ActiveModel::Type::Boolean.new.cast(params[:sync_payments]),
+          sync_sales_orders: ActiveModel::Type::Boolean.new.cast(params[:sync_sales_orders])
         )
 
         integration.save!
 
         if integration.type == 'Integrations::NetsuiteIntegration'
           Integrations::Aggregator::SendRestletEndpointJob.perform_later(integration:)
-          Integrations::Aggregator::PerformSyncJob.set(wait: 2.seconds).perform_later(
-            integration:,
-            sync_tax_items: true
-          )
+          Integrations::Aggregator::PerformSyncJob.set(wait: 2.seconds).perform_later(integration:, sync_items: false)
         end
 
         result.integration = integration

app/services/integrations/netsuite/update_service.rb

@@ -31,10 +31,7 @@ def call
 
         if integration.type == 'Integrations::NetsuiteIntegration' && integration.script_endpoint_url != old_script_url
           Integrations::Aggregator::SendRestletEndpointJob.perform_later(integration:)
-          Integrations::Aggregator::PerformSyncJob.set(wait: 2.seconds).perform_later(
-            integration:,
-            sync_tax_items: true
-          )
+          Integrations::Aggregator::PerformSyncJob.set(wait: 2.seconds).perform_later(integration:, sync_items: false)
         end
 
         result.integration = integration