Feat: invoice custom sections discard mutation (#2939)

## Description

- Added a mutation to trigger InvoiceCustomSection::DestroyService;
- Added single invoice_custom_section resolver

app/graphql/mutations/invoice_custom_sections/destroy.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module Mutations
+  module InvoiceCustomSections
+    class Destroy < BaseMutation
+      include AuthenticableApiUser
+      include RequiredOrganization
+
+      REQUIRED_PERMISSION = 'invoice_custom_sections:delete'
+
+      graphql_name 'DestroyInvoiceCustomSection'
+      description 'Deletes an invoice_custom_section'
+
+      argument :id, ID, required: true
+
+      field :id, ID, null: true
+
+      def resolve(id:)
+        invoice_custom_section = current_organization.invoice_custom_sections.find_by(id:)
+        result = ::InvoiceCustomSections::DestroyService.call(invoice_custom_section:)
+
+        result.success? ? result.invoice_custom_section : result_error(result)
+      end
+    end
+  end
+end

app/graphql/resolvers/customers/invoice_custom_sections_resolver.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+module Resolvers
+  module Customers
+    class InvoiceCustomSectionsResolver < Resolvers::BaseResolver
+    end
+  end
+end

app/graphql/resolvers/invoice_custom_section_resolver.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module Resolvers
+  class InvoiceCustomSectionResolver < Resolvers::BaseResolver
+    include AuthenticableApiUser
+    include RequiredOrganization
+
+    description 'Query a single invoice_custom_section of an organization'
+
+    argument :id, ID, required: true, description: 'Uniq ID of the invoice_custom_section'
+
+    type Types::InvoiceCustomSections::Object, null: false
+
+    def resolve(id: nil)
+      current_organization.invoice_custom_sections.find(id)
+    rescue ActiveRecord::RecordNotFound
+      not_found_error(resource: 'invoice_custom_section')
+    end
+  end
+end

app/graphql/types/mutation_type.rb

@@ -161,6 +161,7 @@ class MutationType < Types::BaseObject
     field :update_api_key, mutation: Mutations::ApiKeys::Update
 
     field :create_invoice_custom_section, mutation: Mutations::InvoiceCustomSections::Create
+    field :destroy_invoice_custom_section, mutation: Mutations::InvoiceCustomSections::Destroy
     field :update_invoice_custom_section, mutation: Mutations::InvoiceCustomSections::Update
   end
 end

app/graphql/types/query_type.rb

@@ -52,6 +52,7 @@ class QueryType < Types::BaseObject
     field :invoice, resolver: Resolvers::InvoiceResolver
     field :invoice_collections, resolver: Resolvers::Analytics::InvoiceCollectionsResolver
     field :invoice_credit_notes, resolver: Resolvers::InvoiceCreditNotesResolver
+    field :invoice_custom_section, resolver: Resolvers::InvoiceCustomSectionResolver
     field :invoice_custom_sections, resolver: Resolvers::InvoiceCustomSectionsResolver
     field :invoiced_usages, resolver: Resolvers::Analytics::InvoicedUsagesResolver
     field :invoices, resolver: Resolvers::InvoicesResolver

app/models/invoice_custom_section.rb

@@ -10,8 +10,10 @@ class InvoiceCustomSection < ApplicationRecord
   validates :name, presence: true
   validates :code, presence: true, uniqueness: {scope: :organization_id}
 
+  default_scope -> { kept }
+
   def selected_for_organization?
-    organization.invoice_custom_sections.exists?(id: id)
+    organization.selected_invoice_custom_sections.exists?(id: id)
   end
 end
 

app/services/invoice_custom_sections/destroy_service.rb

@@ -8,9 +8,11 @@ def initialize(invoice_custom_section:)
     end
 
     def call
+      return result.not_found_failure!(resource: 'invoice_custom_section') unless invoice_custom_section
+
       ActiveRecord::Base.transaction do
         invoice_custom_section.discard
-        Deselect::ForAllUsagesService.call(section: invoice_custom_section).raise_if_error
+        Deselect::ForAllUsagesService.call(section: invoice_custom_section).raise_if_error!
         result.invoice_custom_section = invoice_custom_section
         result
       end

spec/graphql/mutations/invoice_custom_sections/destroy_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Mutations::InvoiceCustomSections::Destroy, type: :graphql do
+  subject(:result) do
+    execute_graphql(
+      current_user: membership.user,
+      current_organization: membership.organization,
+      permissions: required_permission,
+      query:,
+      variables: {input: {id: invoice_custom_section.id}}
+    )
+  end
+
+  let(:query) do
+    <<-GQL
+      mutation($input: DestroyInvoiceCustomSectionInput!) {
+        destroyInvoiceCustomSection(input: $input) { id }
+      }
+    GQL
+  end
+
+  let(:required_permission) { 'invoice_custom_sections:delete' }
+  let(:membership) { create(:membership) }
+  let(:invoice_custom_section) { create(:invoice_custom_section, organization: membership.organization) }
+
+  before { invoice_custom_section }
+
+  it_behaves_like 'requires current user'
+  it_behaves_like 'requires current organization'
+  it_behaves_like 'requires permission', 'invoice_custom_sections:delete'
+
+  context 'when invoice custom section with such ID exists in the current organization' do
+    it 'destroys the invoice custom section' do
+      expect { result }.to change(InvoiceCustomSection, :count).from(1).to(0)
+    end
+  end
+
+  context 'when invoice_custom_section with such ID does not exist in the current organization' do
+    let(:invoice_custom_section) { create(:invoice_custom_section) }
+
+    it 'does not delete the invoice_custom_section' do
+      expect { result }.not_to change(InvoiceCustomSection, :count)
+    end
+
+    it 'returns an error' do
+      expect_graphql_error(result:, message: 'Resource not found')
+    end
+  end
+end