fix(invoice): avoid failure on error not related to taxes

getlago · Sep 12, 2024 · f1f1aec · f1f1aec
1 parent 36110b5
commit f1f1aec
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/services/invoices/subscription_service.rb b/app/services/invoices/subscription_service.rb
@@ -139,7 +139,10 @@ def flag_lifetime_usage_for_refresh
     end
 
     def tax_error?(fee_result)
-      !fee_result.success? && fee_result&.error&.code == 'tax_error'
+      return false if fee_result.success?
+      return false unless fee_result.error.is_a?(BaseService::ServiceFailure)
+
+      fee_result&.error&.code == 'tax_error'
     end
   end
 end