misc(nango): Increase the number of job retries in case of RequestLim…

…itError (#2798) ## Context When generating a lot of invoices at once, Nango starts failing with `Request Limit Exceeded ` error ## Description This PR increases the number of attempts it makes to retry the failed jobs. We're changing it from 10 to 100 attempts with `wait: :polynomially_longer`.
getlago · Nov 8, 2024 · fe3da1a · fe3da1a
1 parent 8da36e9
commit fe3da1a
Show file tree

Hide file tree

Showing 18 changed files with 18 additions and 17 deletions.
diff --git a/app/jobs/integrations/aggregator/credit_notes/create_job.rb b/app/jobs/integrations/aggregator/credit_notes/create_job.rb
@@ -7,7 +7,7 @@ class CreateJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(credit_note:)
           result = Integrations::Aggregator::CreditNotes::CreateService.call(credit_note:)

diff --git a/app/jobs/integrations/aggregator/fetch_items_job.rb b/app/jobs/integrations/aggregator/fetch_items_job.rb
@@ -6,7 +6,7 @@ class FetchItemsJob < ApplicationJob
       queue_as 'integrations'
 
       retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-      retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+      retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
       def perform(integration:)
         result = Integrations::Aggregator::ItemsService.call(integration:)

diff --git a/app/jobs/integrations/aggregator/invoices/create_job.rb b/app/jobs/integrations/aggregator/invoices/create_job.rb
@@ -7,7 +7,7 @@ class CreateJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(invoice:)
           result = Integrations::Aggregator::Invoices::CreateService.call(invoice:)

diff --git a/app/jobs/integrations/aggregator/invoices/crm/create_customer_association_job.rb b/app/jobs/integrations/aggregator/invoices/crm/create_customer_association_job.rb
@@ -8,7 +8,7 @@ class CreateCustomerAssociationJob < ApplicationJob
           queue_as 'integrations'
 
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
-          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
           def perform(invoice:)
             result = Integrations::Aggregator::Invoices::Crm::CreateCustomerAssociationService.call(invoice:)

diff --git a/app/jobs/integrations/aggregator/invoices/crm/create_job.rb b/app/jobs/integrations/aggregator/invoices/crm/create_job.rb
@@ -9,7 +9,7 @@ class CreateJob < ApplicationJob
 
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
-          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
           def perform(invoice:)
             result = Integrations::Aggregator::Invoices::Crm::CreateService.call(invoice:)

diff --git a/app/jobs/integrations/aggregator/invoices/crm/update_job.rb b/app/jobs/integrations/aggregator/invoices/crm/update_job.rb
@@ -9,7 +9,7 @@ class UpdateJob < ApplicationJob
 
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
-          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
           def perform(invoice:)
             result = Integrations::Aggregator::Invoices::Crm::UpdateService.call(invoice:)

diff --git a/app/jobs/integrations/aggregator/payments/create_job.rb b/app/jobs/integrations/aggregator/payments/create_job.rb
@@ -7,7 +7,7 @@ class CreateJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 5
-        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(payment:)
           result = Integrations::Aggregator::Payments::CreateService.call(payment:)

diff --git a/app/jobs/integrations/aggregator/perform_sync_job.rb b/app/jobs/integrations/aggregator/perform_sync_job.rb
@@ -6,7 +6,7 @@ class PerformSyncJob < ApplicationJob
       queue_as 'integrations'
 
       retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-      retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+      retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
       def perform(integration:, sync_items: true)
         sync_result = Integrations::Aggregator::SyncService.call(integration:)

diff --git a/app/jobs/integrations/aggregator/sales_orders/create_job.rb b/app/jobs/integrations/aggregator/sales_orders/create_job.rb
@@ -7,7 +7,7 @@ class CreateJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(invoice:)
           result = Integrations::Aggregator::SalesOrders::CreateService.call(invoice:)

diff --git a/app/jobs/integrations/aggregator/send_restlet_endpoint_job.rb b/app/jobs/integrations/aggregator/send_restlet_endpoint_job.rb
@@ -6,7 +6,7 @@ class SendRestletEndpointJob < ApplicationJob
       queue_as 'integrations'
 
       retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-      retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+      retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
       def perform(integration:)
         result = Integrations::Aggregator::SendRestletEndpointService.call(integration:)

diff --git a/app/jobs/integrations/aggregator/subscriptions/crm/create_customer_association_job.rb b/app/jobs/integrations/aggregator/subscriptions/crm/create_customer_association_job.rb
@@ -8,7 +8,7 @@ class CreateCustomerAssociationJob < ApplicationJob
           queue_as 'integrations'
 
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
-          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
           def perform(subscription:)
             result = Integrations::Aggregator::Subscriptions::Crm::CreateCustomerAssociationService.call(subscription:)

diff --git a/app/jobs/integrations/aggregator/subscriptions/crm/create_job.rb b/app/jobs/integrations/aggregator/subscriptions/crm/create_job.rb
@@ -9,7 +9,7 @@ class CreateJob < ApplicationJob
 
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
-          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
           def perform(subscription:)
             result = Integrations::Aggregator::Subscriptions::Crm::CreateService.call(subscription:)

diff --git a/app/jobs/integrations/aggregator/subscriptions/crm/update_job.rb b/app/jobs/integrations/aggregator/subscriptions/crm/update_job.rb
@@ -9,7 +9,7 @@ class UpdateJob < ApplicationJob
 
           retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 10
           retry_on Integrations::Aggregator::BasePayload::Failure, wait: :polynomially_longer, attempts: 10
-          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 10
+          retry_on RequestLimitError, wait: :polynomially_longer, attempts: 100
 
           def perform(subscription:)
             result = Integrations::Aggregator::Subscriptions::Crm::UpdateService.call(subscription:)

diff --git a/app/jobs/integrations/hubspot/companies/deploy_properties_job.rb b/app/jobs/integrations/hubspot/companies/deploy_properties_job.rb
@@ -7,7 +7,7 @@ class DeployPropertiesJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(integration:)
           result = Integrations::Hubspot::Companies::DeployPropertiesService.call(integration:)

diff --git a/app/jobs/integrations/hubspot/contacts/deploy_properties_job.rb b/app/jobs/integrations/hubspot/contacts/deploy_properties_job.rb
@@ -7,7 +7,7 @@ class DeployPropertiesJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(integration:)
           result = Integrations::Hubspot::Contacts::DeployPropertiesService.call(integration:)

diff --git a/app/jobs/integrations/hubspot/invoices/deploy_object_job.rb b/app/jobs/integrations/hubspot/invoices/deploy_object_job.rb
@@ -7,7 +7,7 @@ class DeployObjectJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(integration:)
           result = Integrations::Hubspot::Invoices::DeployObjectService.call(integration:)

diff --git a/app/jobs/integrations/hubspot/save_portal_id_job.rb b/app/jobs/integrations/hubspot/save_portal_id_job.rb
@@ -6,6 +6,7 @@ class SavePortalIdJob < ApplicationJob
       queue_as 'integrations'
 
       retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
+      retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 100
 
       def perform(integration:)
         result = Integrations::Hubspot::SavePortalIdService.call(integration:)

diff --git a/app/jobs/integrations/hubspot/subscriptions/deploy_object_job.rb b/app/jobs/integrations/hubspot/subscriptions/deploy_object_job.rb
@@ -7,7 +7,7 @@ class DeployObjectJob < ApplicationJob
         queue_as 'integrations'
 
         retry_on LagoHttpClient::HttpError, wait: :polynomially_longer, attempts: 3
-        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 10
+        retry_on Integrations::Aggregator::RequestLimitError, wait: :polynomially_longer, attempts: 100
 
         def perform(integration:)
           result = Integrations::Hubspot::Subscriptions::DeployObjectService.call(integration:)