Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(override-plan): Discard plan and children #1342

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Sep 21, 2023

Context

We want to improve the way we are overriding a plan. Without working as a duplicate, by adding the logic for managing parent and children of plans.

Description

The goal of this PR is to:

  • track overridden plans on Segment
  • be able to discard a plan and children

@rsempe rsempe added the Plan Related to Plans label Sep 21, 2023
@rsempe rsempe force-pushed the delete-subscription branch 4 times, most recently from d07e2fe to af47a2c Compare September 21, 2023 15:44
@rsempe rsempe force-pushed the update-subscription branch from 4c8e091 to fde8025 Compare September 22, 2023 06:55
@rsempe rsempe force-pushed the delete-subscription branch from af47a2c to 40561c5 Compare September 22, 2023 06:56
@rsempe rsempe force-pushed the update-subscription branch 2 times, most recently from cefe483 to 3b3fd14 Compare September 22, 2023 07:59
Base automatically changed from update-subscription to main September 22, 2023 08:02
@rsempe rsempe force-pushed the delete-subscription branch from 40561c5 to a5c62c9 Compare September 22, 2023 08:03
@rsempe rsempe merged commit 69a8470 into main Sep 22, 2023
5 checks passed
@rsempe rsempe deleted the delete-subscription branch September 22, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plan Related to Plans
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants