fix (jobs-inside-transaction): add setup for after commit everywhere and fix customer.vies_check webhook #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
requested review from
rsempe,
ivannovosad,
vincent-pochet and
jdenquin
ivannovosad
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Common scenario in Lago is that we have to trigger active job inside DB transaction. SInce job tries to fetch and use record that is saved inside transaction, we often end up with
ActiveJob::DeserializationErrorif job is processed before transaction commit command.Description
We usually handle this issue by setting wait parameter to 3 seconds upon calling active job.
This PR sets up
ActiveCommitEverywheregem so that we can handle this issue without a 3 seconds hack.Also, as part of this PR new library is used to correctly call
customer.vies_checkwebhook.