Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unique-count): Prorated unique count queries #1704

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Context

The goal is to refactor the way we’re doing the aggregation for the unique count.

Description

The goal of this PR is to add the handle prorated recurring logic for unique count aggregation

The SQL logic has been extracted into Events::Stores::Clickhouse::UniqueCountQuery.

@vincent-pochet vincent-pochet self-assigned this Feb 16, 2024
@vincent-pochet vincent-pochet merged commit 35d3cbd into main Feb 16, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the feat-unique-count-prorated-recurring branch February 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants