Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unique_count): Add active_unique_property to event stores #1710

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

vincent-pochet
Copy link
Collaborator

Context

The goal is to refactor the way we’re doing the aggregation for the unique count.

Description

The goal of this PR is to add the method Events::Stores::ClickhouseStore#active_unique_property? and Events::Stores::PostgresStore#active_unique_property?.

The PR also adds small fixes and refact

@vincent-pochet vincent-pochet self-assigned this Feb 20, 2024
@rsempe rsempe merged commit 6387623 into main Feb 21, 2024
6 checks passed
@rsempe rsempe deleted the fix-typo branch February 21, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants