fix(subscriptions): fix edit subscription attached to parent plan #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
requested review from
rsempe,
ivannovosad,
vincent-pochet and
jdenquin
jdenquin
reviewed
Feb 21, 2024
lovrocolic
force-pushed
the
fix-edit-subscription
branch
from
a91e667 to
0803e2f
Compare
vincent-pochet
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Subscription edition works in a way that it changes plan's values. It works fine if subscription is attached to overridden plan.
However, if subscription is attached to parent plan it will change also values on all other subscriptions.