feat: Add ability to soft delete fees #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
force-pushed
the
feat-add-fee-soft-deletion
branch
3 times, most recently
from
94cc5d4 to
cced041
Compare
brunomiguelpinto
force-pushed
the
feat-add-fee-soft-deletion
branch
from
cced041 to
25f0d13
Compare
julienbourdeau
approved these changes
Jul 8, 2024
This was referenced Jul 10, 2024
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We already utilize the
discardgem for soft deletion in other models within our application. However, the fees model currently lacks this functionality. Additionally, there is a need to ensure that fees associated with invoices are protected from deletion to maintain data integrity.Description
This PR extends the use of the
discardgem to the fees model, enabling the soft deletion of fees. Furthermore, a validation is added to ensure that only fees not attached to any invoice can be deleted. If a deletion attempt is made on a fee associated with an invoice, the system will respond with a405 Method Not Allowedstatus and an error codeinvoiced_fee. This ensures that while fees can be logically removed from active use, those associated with invoices remain intact, preserving the integrity of invoice-related data.