Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Discard Handling for AuthenticationError #2239

Merged
merged 7 commits into from
Jul 5, 2024
Merged

feat: Add Discard Handling for AuthenticationError #2239

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f45102
feat: add discard on AuthenticationError
brunomiguelpinto Jul 2, 2024
23cf10e
feat: added logger
brunomiguelpinto Jul 3, 2024
d45c262
feat: unified the rescue handler
brunomiguelpinto Jul 4, 2024
c4d5a43
feat: unified the rescue handler
brunomiguelpinto Jul 4, 2024
f23714c
feat: unified the rescue handler
brunomiguelpinto Jul 4, 2024
e2d391e
Update stripe_service.rb
brunomiguelpinto Jul 5, 2024
f977e2f
feat: fix typo
brunomiguelpinto Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions app/services/invoices/payments/stripe_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,19 @@ def create

result.payment = payment
result
rescue Stripe::AuthenticationError, Stripe::CardError, Stripe::InvalidRequestError, Stripe::PermissionError => e
# NOTE: Do not mark the invoice as failed if the amount is too small for Stripe
# For now we keep it as pending, the user can still update it manually
return if e.code == 'amount_too_small'

deliver_error_webhook(e)
update_invoice_payment_status(payment_status: :failed, deliver_webhook: false)
nil
rescue Stripe::RateLimitError, Stripe::APIConnectionError
raise # Let the auto-retry process do its own job
rescue Stripe::StripeError => e
deliver_error_webhook(e)
raise
end

def update_payment_status(organization_id:, provider_payment_id:, status:, metadata: {})
Expand Down Expand Up @@ -175,9 +188,6 @@ def update_payment_method_id
if (payment_method_id = result.invoice_settings.default_payment_method || result.default_source)
customer.stripe_customer.update!(payment_method_id:)
end
rescue Stripe::StripeError => e
deliver_error_webhook(e)
raise
end

def create_stripe_payment
Expand All @@ -190,14 +200,6 @@ def create_stripe_payment
idempotency_key: "#{invoice.id}/#{invoice.payment_attempts}"
}
)
rescue Stripe::CardError, Stripe::InvalidRequestError, Stripe::PermissionError => e
# NOTE: Do not mark the invoice as failed if the amount is too small for Stripe
# For now we keep it as pending, the user can still update it manually
return if e.code == 'amount_too_small'

deliver_error_webhook(e)
update_invoice_payment_status(payment_status: :failed, deliver_webhook: false)
nil
end

def stripe_payment_payload
Expand Down