feat(applied-taxes): add logic for creating applied taxes based on external provider #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
reviewed
Jul 10, 2024
vincent-pochet
approved these changes
Jul 12, 2024
lovrocolic
force-pushed
the
apply-anrok-taxes
branch
from
869a8e0 to
727f80c
Compare
lovrocolic
force-pushed
the
apply-anrok-taxes
branch
from
727f80c to
9fe2ff4
Compare
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
…ternal provider (getlago#2267) ## Context Currently Anrok - tax tool integration is being added ## Description This PR created applied taxes objects in Lago based on fetched Anrok taxes. Two new services are added: `Fees::ApplyProviderTaxesService` and `Invoices::ApplyProviderTaxesService`. This logic follows existing behaviour in `Fees::ApplyTaxesService` and `Invoices::ApplyTaxesService` services. The only difference is that source of taxes is not Lago app anymore but external provider. New services are not used yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently Anrok - tax tool integration is being added
Description
This PR created applied taxes objects in Lago based on fetched Anrok taxes.
Two new services are added:
Fees::ApplyProviderTaxesServiceandInvoices::ApplyProviderTaxesService.This logic follows existing behaviour in
Fees::ApplyTaxesServiceandInvoices::ApplyTaxesServiceservices. The only difference is that source of taxes is not Lago app anymore but external provider.New services are not used yet.