feat(ProgressiveBilling) - automated CreditNote generation at the periodic invoice if needed #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
changed the title
nudded
force-pushed
the
feat-prog-billing-create-credit-note
branch
from
c8e1b87 to
1c848c5
Compare
nudded
force-pushed
the
feat-prog-billing-create-credit-note
branch
from
1c848c5 to
6a68113
Compare
app/services/credit_notes/create_from_progressive_billing_invoice.rb
Outdated
Show resolved
Hide resolved
vincent-pochet
approved these changes
Aug 26, 2024
nudded
force-pushed
the
feat-prog-billing-create-credit-note
branch
2 times, most recently
from
78e2247 to
09a85b8
Compare
nudded
force-pushed
the
feat-prog-billing-create-credit-note
branch
from
09a85b8 to
406533e
Compare
nudded
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI companies want their users to pay before the end of a period if usage skyrockets. The problem being that self-serve companies can overuse their API without paying, triggering lots of costs on their side.
Description
Whenever we credit already invoiced progressive billing invoices at the periodic invoice, we could end up in a situation that leaves more to credit than invoicable. At that point we'll create credit notes for past progressive billing invoices.
This adds a
CreditNotes::CreateFromProgressiveBillingInvoiceservice that will take care of distributing the amount to credit over all fees.Also updates
debuggem and allows for remote debugging whenENV['RUBY_DEBUG_PORT']is set