Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add firstname and last name to queries #2553

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

brunomiguelpinto
Copy link
Contributor

@brunomiguelpinto brunomiguelpinto commented Sep 9, 2024

Context

We have enhanced the search functionality for both Customers and Invoices to allow searches by firstname and lastname fields, in addition to the existing name field.

@brunomiguelpinto brunomiguelpinto added Customer Customer management Invoice Related to Invoices labels Sep 9, 2024
@brunomiguelpinto brunomiguelpinto self-assigned this Sep 9, 2024
@brunomiguelpinto brunomiguelpinto marked this pull request as draft September 9, 2024 16:22
@brunomiguelpinto brunomiguelpinto marked this pull request as ready for review September 9, 2024 17:01
spec/queries/customers_query_spec.rb Outdated Show resolved Hide resolved
Co-authored-by: Ivan Novosad <ivannovosad@users.noreply.github.com>
@brunomiguelpinto brunomiguelpinto changed the title feat: added firstname and last name to queries feat: Add firstname and last name to queries Sep 10, 2024
@brunomiguelpinto brunomiguelpinto merged commit 489c17b into main Sep 10, 2024
6 checks passed
@brunomiguelpinto brunomiguelpinto deleted the feat-customer-type-queries branch September 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Customer management Invoice Related to Invoices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants