Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invoice): avoid failure on error not related to taxes #2576

Merged
merged 1 commit into from
Sep 12, 2024
+4 −1
Merged

fix(invoice): avoid failure on error not related to taxes #2576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/services/invoices/subscription_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ def flag_lifetime_usage_for_refresh
end

def tax_error?(fee_result)
!fee_result.success? && fee_result&.error&.code == 'tax_error'
return false if fee_result.success?
vincent-pochet marked this conversation as resolved.
Show resolved Hide resolved
return false unless fee_result.error.is_a?(BaseService::ServiceFailure)

fee_result.error.code == 'tax_error'
end
end
end