feat(PreciseAmountRounding) - format precise numbers with 6 significant digits #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
force-pushed
the
feat-round-unit-price-significant-decimals
branch
from
b136f32 to
03258b0
Compare
nudded
force-pushed
the
feat-round-unit-price-significant-decimals
branch
from
03258b0 to
f168da2
Compare
vincent-pochet
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To calculate the unit price of a fee linked to a dynamic charge, we do: total_amount / units = unit_price. This value can be really long.
Solution
We’ll introduce the notion of significant digits for fee unit price: We hide values if they are not significant (0).