misc(stripe): Refact payment method update webhooks #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
fix-refact-stripe-payment-method-update
branch
3 times, most recently
from
aaba01a to
d12a15b
Compare
nudded
reviewed
Nov 13, 2024
app/services/payment_provider_customers/stripe/update_payment_method_service.rb
Outdated
Show resolved
Hide resolved
nudded
reviewed
Nov 13, 2024
app/services/payment_providers/webhooks/stripe/setup_intent_succeeded_service.rb
Show resolved
Hide resolved
nudded
requested changes
Nov 13, 2024
vincent-pochet
force-pushed
the
fix-refact-stripe-payment-method-update
branch
2 times, most recently
from
8d527b4 to
12d353d
Compare
vincent-pochet
force-pushed
the
fix-refact-stripe-payment-method-update
branch
from
12d353d to
5d2c14c
Compare
nudded
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is related to the remaining
PaymentProviders::Stripe::HandleEventJobdead jobs withBaseService::NotFoundFailure: stripe_customer_not_founderrorDescription
The main goal of the PR is to refactor the handling of the
setup_intent.succeededandcustomer.updatedto move the logic in a dedicated webhook service (in the objective of killing the unmaintainablePaymentProviderCustomers::StripeService).It also fixes a case in
setup_intent.succeededwhen the webhook has acustomerwith null value and no Lago ids in the metadata. Since in this specif case the webhook does not target a lago resource, the handling should not raise an error but should be ignored.