fix: Plans::UpdateAmountService handle pending subscription upgrades #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context in `cascade_subscription_fee_update` we call `Plans::UpdateAmountJob`. This job should deal with pending subscriptions similar to how the `Plans::UpdateService` does it. (see `process_downgrade`|`pending_subscriptions`) ## Description This changes handles subscription upgrades when plan amount_cents changes because of cascading from parent plan and there are pending subscriptions.
nudded
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
in
cascade_subscription_fee_updatewe callPlans::UpdateAmountJob. This job should deal with pending subscriptions similar to how thePlans::UpdateServicedoes it. (seeprocess_downgrade|pending_subscriptions)Description
This changes handles subscription upgrades when plan amount_cents changes because of cascading from parent plan and there are pending subscriptions.