fix (grace_period): refactor how issuing date is set #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
commented
Dec 9, 2024
nudded
reviewed
Dec 10, 2024
vincent-pochet
approved these changes
Dec 10, 2024
nudded
reviewed
Dec 10, 2024
lovrocolic
force-pushed
the
fix-issuing-date-calc
branch
from
d3b3712 to
71ec130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When billing job is triggered in the past,
issuing_dateis not set correctly.Description
issuing_dateis set based on the billing job timestamp and grace period.However, when we check if it is correct time to finalize invoice or in services that set grace period we calculate issuing date again based on
invoice.created_at. Ifinvoice.created_atis different than billing day timestamp, we could end-up with invalid issuing date. This especially affects when the draft invoice is finalized.@vincent-pochet @rsempe Can you see any downside of this approach?