feat: centralize determine payment status #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
force-pushed
the
feat-determine-payment-status
branch
from
f39a4b7 to
33bd737
Compare
vincent-pochet
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This Pull Request is to backfill the payable_payment_status field for the Payment model and to centralize the status per provider
Description
This Pull Request introduces a reusable method determine_payment_status to the BaseProvider class, centralizing the logic for payment status determination. It also adds provider-specific status constants (PENDING_STATUSES, SUCCESS_STATUSES, FAILED_STATUSES)
and adds a migration to do the backfilling and the payable_payment_status