Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (invoice_custom_sections): refactor invoice_custom_sections inclusion #3006

Open
wants to merge 11 commits into
base: feat-invoice-custom-sections-customer-update-service
Choose a base branch
from

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented Dec 24, 2024

Description

Included invoice_custom_sections into customer object rather than a separate resolver

Include invoice_custom_section management from customer update mutation

@annvelents annvelents changed the title refactor invoice_custom_sections inclusion Feat (invoice_custom_sections): refactor invoice_custom_sections inclusion Dec 26, 2024
@annvelents annvelents marked this pull request as ready for review December 26, 2024 10:15
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved... left a few comments.

app/services/customers/update_service.rb Outdated Show resolved Hide resolved
spec/graphql/resolvers/customer_resolver_spec.rb Outdated Show resolved Hide resolved
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-mutation branch from 6ecaf98 to 1151333 Compare December 30, 2024 14:14
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-service branch from 2e1e5f6 to 20472d8 Compare December 30, 2024 15:42
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-mutation branch from 1151333 to 16debc9 Compare December 30, 2024 15:43
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-mutation branch from 8dba59d to b99d81b Compare December 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants