misc(fee): Delete zero amount finalized fees #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
reviewed
Jan 3, 2025
rsempe
approved these changes
Jan 3, 2025
vincent-pochet
force-pushed
the
misc-cleanup-zero-amount-fees
branch
from
3db1342 to
c076121
Compare
jdenquin
approved these changes
Jan 3, 2025
vincent-pochet
force-pushed
the
misc-cleanup-zero-amount-fees
branch
10 times, most recently
from
75cecc5 to
4ad3b8a
Compare
jdenquin
approved these changes
Jan 6, 2025
nudded
approved these changes
Jan 6, 2025
vincent-pochet
force-pushed
the
misc-cleanup-zero-amount-fees
branch
3 times, most recently
from
20876ed to
5692302
Compare
vincent-pochet
force-pushed
the
misc-cleanup-zero-amount-fees
branch
3 times, most recently
from
d74c0ef to
de29802
Compare
vincent-pochet
added a commit
that referenced
this pull request
Jan 16, 2025
## Description This PR follow #3020 the goal is to stop generating empty fees (0 units, amount and events without adjustments or true up fees). The reason behind this change is scalability as for now, depending on the plan setups, it appears that 98% of generated fees does not have an amount... **NOTE:** a new feature will improve the edit fees feature since this PR will prevent creation of adjustment fees from the UI if no event have been received for a specific billable metric on a period.
vincent-pochet
force-pushed
the
misc-cleanup-zero-amount-fees
branch
from
de29802 to
b808087
Compare
vincent-pochet
force-pushed
the
misc-cleanup-zero-amount-fees
branch
2 times, most recently
from
1f5cf35 to
37c21e1
Compare
vincent-pochet
added a commit
that referenced
this pull request
Jan 27, 2025
#3059) (#3068) ## Description This PR follow #3020 the goal is to stop generating empty fees (0 units, amount and events without adjustments or true up fees). The reason behind this change is scalability as for now, depending on the plan setups, it appears that 98% of generated fees does not have an amount... **NOTE:** a new feature will improve the edit fees feature since this PR will prevent creation of adjustment fees from the UI if no event have been received for a specific billable metric on a period.
vincent-pochet
force-pushed
the
misc-cleanup-zero-amount-fees
branch
from
37c21e1 to
9e1f1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the charge fees attached to finalized or voided invoices and having
amount = 0.In a close future, these fees will not be generated anymore, and the logic built around it will be refactored (adjusted fees, daily_usage computation...)