Feat(revshare): self billed invoices numbering #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add tests for customer creation with account type partner
- remove filter customers by account type - fix linter issues - do not allow to update customer account type if customer is not editable - fix tests
also fix a test that was not ok
## Roadmap Task 👉 https://getlago.canny.io/feature-requests/p/{{FEATURE_SLUG}} ## Context Include relevant motivation and context. ## Description Describe your changes in detail. List any dependencies that are required.
ancorcruz
approved these changes
Jan 20, 2025
spec/scenarios/customers/create_partner_and_run_billing_spec.rb
Outdated
Show resolved
Hide resolved
spec/scenarios/customers/create_partner_and_run_billing_spec.rb
Outdated
Show resolved
Hide resolved
spec/scenarios/customers/create_partner_and_run_billing_spec.rb
Outdated
Show resolved
Hide resolved
spec/scenarios/customers/create_partner_and_run_billing_spec.rb
Outdated
Show resolved
Hide resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/calculate-revenue-share
Context
Self-billed invoices should be numbered by customer and should not affect rest of the invoices generated for the organization
Description
Modified rules for numbering to not include self-billed invoices when calculating sequential id
Always use customer numbering for self-billed invoices
Added self-billed invoice scenario test